Allow override of extract command for archives #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Sep 24, 2017
manifests/params.pp
Outdated
| @@ -1,6 +1,8 @@ | |||
| # Class prometheus::params | |||
| # Include default parameters for prometheus class | |||
| class prometheus::params { | |||
| class prometheus::params ( | |||
| $extract_command = undef, | |||
There was a problem hiding this comment.
this should not be a parameter of the params class
There was a problem hiding this comment.
Happy to change it. Can you please advise how it should be structured/refactored?
There was a problem hiding this comment.
this should be a normal variable and not a parameter.
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Allow override of extract command for archives
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Allow override of extract command for archives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usecase:
The current
puppet-archiveextraction logic preserves the uid/gid in the tarball when extracting. This will permit users of GNU tar to use something like '--no-same-owner' or similar for their platform.