Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace validate_* with datatypes in init #75

Merged
merged 1 commit into from
Oct 21, 2017
Merged

replace validate_* with datatypes in init #75

merged 1 commit into from
Oct 21, 2017

Conversation

bastelfreak
Copy link
Member

No description provided.

wyardley
wyardley approved these changes Oct 21, 2017
View reviewed changes
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... Some of the other data types are obvious, and probably foo_real should get updated to _foo, but those can all be done separately.

@wyardley wyardley merged commit 1fb547f into voxpupuli:master Oct 21, 2017
@bastelfreak bastelfreak deleted the puppet4 branch October 21, 2017 23:29
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this pull request May 5, 2021
@wyardley
Merge pull request voxpupuli#75 from bastelfreak/puppet4
6d846cf 
replace validate_* with datatypes in init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyardley wyardley wyardley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastelfreak @wyardley