Do a daemon reload for static units #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Services that are deployed by systemd::timer need to trigger a
`systemctl daemon-reload` when the .service file is changed.
systemd::timer { 'foo.timer':
timer_content => $foo_timer,
service_content => $foo_service,
active => true,
enable => true,
}
results in a foo.service that is neither active nor enabled. It is
a "static" unit that will be triggered by the foo.timer alone. This
fixes voxpupuli#190 and more specifically:
voxpupuli#190 (comment)
Signed-off-by: Simon Deziel <[email protected]>
|
Can you also update the tests in https://github.com/voxpupuli/puppet-systemd/blob/master/spec/defines/unit_file_spec.rb to cover this? That way we don't have a regression. |
|
@simondeziel do you think you could add a test for this? |
simondeziel
added a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Oct 19, 2021
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
added a commit
to simondeziel/puppet-systemd
that referenced
this pull request
Oct 19, 2021
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
static-unit
branch
from
03f2939
to
6c4de90
Compare
Signed-off-by: Simon Deziel <[email protected]>
simondeziel
force-pushed
the
static-unit
branch
from
6c4de90
to
b705e44
Compare
bastelfreak
approved these changes
Oct 19, 2021
trevor-vaughan
added a commit
that referenced
this pull request
Jun 10, 2022
* Add a `systemd::daemon_reload` defined type * Ensure that any file additions to the /etc/systemd/system space are followed by a call to `systemd::daemon_reload` * Allow users to disable the calls to `systemd::daemon_reload` * Allow users to globally disable the `systemctl daemon-reload` exec using a resource collector if necessary * Hook the daemon reload between the file creation and the service as is usually necessary, where possible Fixes #234 Fixes #199
trevor-vaughan
added a commit
that referenced
this pull request
Jun 10, 2022
* Add a `systemd::daemon_reload` defined type * Ensure that any file additions to the /etc/systemd/system space are followed by a call to `systemd::daemon_reload` * Allow users to disable the calls to `systemd::daemon_reload` * Allow users to globally disable the `systemctl daemon-reload` exec using a resource collector if necessary * Hook the daemon reload between the file creation and the service as is usually necessary, where possible * Add a 'best effort' optional exec as `systemd::lazy_daemon_reload` to try and clean up systems that were modified betweedn 2.9.0 and this release Fixes #234 Fixes #199
trevor-vaughan
added a commit
that referenced
this pull request
Jun 17, 2022
* Add a `systemd::daemon_reload` defined type * Ensure that any file additions to the /etc/systemd/system space are followed by a call to `systemd::daemon_reload` * Allow users to disable the calls to `systemd::daemon_reload` * Allow users to globally disable the `systemctl daemon-reload` exec using a resource collector if necessary * Hook the daemon reload between the file creation and the service as is usually necessary, where possible * Add a 'best effort' optional exec as `systemd::lazy_daemon_reload` to try and clean up systems that were modified betweedn 2.9.0 and this release Fixes #234 Fixes #199 Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services that are deployed by systemd::timer need to trigger a
systemctl daemon-reloadwhen the .service file is changed.results in a
foo.servicethat is neither active nor enabled. It is a "static" unit that will be triggered by thefoo.timeralone. This fixes #190 and more specifically: #190 (comment)