Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Datatype Sensitive for $content #201

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Accept Datatype Sensitive for $content #201

merged 1 commit into from
Jul 12, 2021

Conversation

cocker-cc
Copy link
Contributor

  • just as for systemd::dropin_file, accept Datatype Sensitive for $content

ekohl
ekohl reviewed Jul 5, 2021
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a file type accept Sensitive? Would you mind adding a test for it to ensure that works?

@cocker-cc
Copy link
Contributor Author

cocker-cc commented Jul 5, 2021 •
edited
Loading

Can a file type accept Sensitive? Would you mind adding a test for it to ensure that works?

Done: compare this

@bastelfreak
Copy link
Member

@cocker-cc we fixed the CI pipeline. Can you please rebase against our latest master branch?

@cocker-cc
Copy link
Contributor Author

cocker-cc commented Jul 12, 2021 •
edited
Loading

@cocker-cc we fixed the CI pipeline. Can you please rebase against our latest master branch?

Done.
Additionally fixed some rubocop-Complaints.

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 12, 2021
Accept Datatype Sensitive for $content
95f1d66 
- just as for systemd::dropin_file, accept Datatype Sensitive for $content
- Rspec-Test for sensitive Content
@bastelfreak bastelfreak merged commit a7c76fa into voxpupuli:master Jul 12, 2021
@cocker-cc cocker-cc deleted the Accept_Datatype_Sensitive branch July 12, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cocker-cc @bastelfreak @ekohl