Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of Trivial Acceptance Tests #255

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Addition of Trivial Acceptance Tests #255

merged 3 commits into from
Feb 21, 2022

Conversation

traylenator
Copy link
Contributor

Pull Request (PR) description

Addition of trivial acceptance tests

@bastelfreak
Copy link
Member

We need a new modulesync to update https://github.com/voxpupuli/puppet-systemd/blob/master/.github/workflows/ci.yml. when the tests are present and modulesync is run, the CI file is updated to run the acceptance tests.

ekohl
ekohl reviewed Feb 21, 2022
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Acceptance tests are so useful.

spec/acceptance/systemd_spec.rb Outdated Show resolved Hide resolved
@traylenator
Copy link
Contributor Author

This is what are feared, you very quickly start running to weird things about these hosts:

Error: /Stage[main]/Systemd::Resolved/File[/etc/resolv.conf]/ensure: change from 'file' to 'link' failed: Device or resource busy @ apply2files - /etc/resolv.conf

@ekohl
Copy link
Member

ekohl commented Feb 21, 2022

I've used default[:hypervisor] == 'docker' to determine if it's running inside docker. If you'd have a parameter like $manage_resolv_conf you could use this. In this particular case, we don't so that makes it harder.

@traylenator
Copy link
Contributor Author

That;s probably enough in here for now:

  • I'll pull out the manage_resolv_conf to it's own MR.
  • Disable the checks on CentOS as there is indeed no resolved to be had.

@traylenator
Copy link
Contributor Author

#256 first for the extra parameter.

ekohl
ekohl reviewed Feb 21, 2022
View reviewed changes
spec/acceptance/resolved_spec.rb Outdated Show resolved Hide resolved
spec/acceptance/resolved_spec.rb Outdated Show resolved Hide resolved
@traylenator traylenator marked this pull request as ready for review February 21, 2022 15:05
@traylenator traylenator merged commit 01a7915 into voxpupuli:master Feb 21, 2022
@traylenator traylenator deleted the accept branch February 21, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak approved these changes

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@traylenator @bastelfreak @ekohl