Make compatible with strict variables. #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobVincentatNCRdotcom
force-pushed
the
master
branch
3 times, most recently
from
5f5af57
to
1f22ae8
Compare
BobVincentatNCRdotcom
force-pushed
the
master
branch
from
1f22ae8
to
b48e733
Compare
|
I have filed a bug report with Puppet including test code demonstrating that unset metaparameters are not assigned default values: https://tickets.puppetlabs.com/browse/PUP-5603 Update: The metaparameter bug was fixed in Puppet 4.3.0; see next comment. |
This was referenced Dec 12, 2015
|
Looks like the $schedule parameter workaround is only needed for puppet versions 4.0.0 - 4.2.3 inclusive. Puppet 4.3.0 fixes the bug. The $http_proxy and $https_proxy code is still necessary, unless you prefer the workaround suggested in #68 |
This was referenced Dec 28, 2015
carlossg
added a commit
that referenced
this pull request
Mar 1, 2016
Make compatible with strict variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puppet 4 with strict variables aborts when referencing unset variables. Note that "unset" is not the same as "explicitly assigned an undef value".