[RFC] COPR support

[olifre]

This module does not have support for COPR yet, i.e. repos from https://copr.fedorainfracloud.org which are handled via yum-plugin-copr or dnf-plugins-core.

This is an RFC to find out if:

• Devs think this should be in the scope of this module.
• How to best implement it.

To trigger off discussion a bit, I am currently using a custom ressource defined like this:

define profile::repo::copr(
        String                                  $copr_repo      = $title,
        Enum['enabled', 'disabled', 'removed']  $ensure         = 'enabled',
) {
  $prereq_plugin = $facts['package_provider'] ? {
    'dnf'   => 'dnf-plugins-core',
    default => 'yum-plugin-copr',
  }
  ensure_packages([ $prereq_plugin ])
  if $facts['package_provider'] == 'dnf' {
    case $ensure {
      'enabled':
        {
          exec { "dnf -y copr enable ${copr_repo}":
            unless  => "dnf copr list | egrep -q '${copr_repo}\$'",
            require => Package[$prereq_plugin],
          }
        }
      'disabled':
        {
          exec { "dnf -y copr disable ${copr_repo}":
            unless  => "dnf copr list | egrep -q '${copr_repo} (disabled)\$'",
            require => Package[$prereq_plugin],
          }
        }
      'removed':
        {
          exec { "dnf -y copr remove ${copr_repo}":
            unless  => "dnf copr list | egrep -q '${copr_repo}'",
            require => Package[$prereq_plugin],
          }
        }
    }
  } else {
    $copr_repo_name_part = regsubst($copr_repo, '/', '-', 'G')
    case $ensure {
      'enabled':
        {
          exec { "yum -y copr enable ${copr_repo}":
            onlyif  => "test ! -e /etc/yum.repos.d/_copr_${copr_repo_name_part}.repo",
          }
        }
      'disabled', 'removed':
        {
          exec { "yum -y copr disable ${copr_repo}":
            onlyif  => "test -e /etc/yum.repos.d/_copr_${copr_repo_name_part}.repo",
          }
        }
    }
  }
}

which allows me to do:

profile::repo::copr { 'copart/restic':
  ensure  => 'enabled',
}

[dhoppe]

@traylenator I think this would be a great enhancement.

[NoodlesNZ]

Sounds fantastic. Can you create a PR?

[olifre]

Sounds fantastic. Can you create a PR?

Done, sorry it took me so long — I needed some time to learn how to write a working test 😉.