Add yum::copr resource to handle COPR repositories. #215

olifre · 2021-06-10T10:43:38Z

COPR (Cool Other Package Repo) is a Fedora project for third-party package repositories, see:
https://copr.fedorainfracloud.org/

Pull Request (PR) description

This PR adds support to manage COPR repositories via a new yum::copr resource.
Documentation and test are included.

This Pull Request (PR) fixes the following issues

Fixes #149

traylenator

This is a good case for an acceptance test as well I'd say.

traylenator · 2021-06-28T13:28:38Z

manifests/copr.pp

+#   }
+#
+define yum::copr (
+  String                                 $copr_repo = $title,


Variable $repo is proably enough since it's already in yum::copr type.

Indeed, I changed that in the last force push 👍 .

traylenator · 2021-06-28T13:50:39Z

manifests/copr.pp

+  Enum['enabled', 'disabled', 'removed'] $ensure    = 'enabled',
+) {
+  $prereq_plugin = $facts['package_provider'] ? {
+    'dnf'   => 'dnf-plugins-core',


I always prefer to make the future, dnf in this case, the default case since it's more obvious what code needs removing once yum is gone from the universe.

That's a good idea, thanks for the suggestion! I've also addressed this in the last push.

olifre · 2021-06-28T14:20:00Z

This is a good case for an acceptance test as well I'd say.

Indeed it is. I've addressed all comments apart from the acceptance test, will look into this later this week.

bastelfreak · 2021-06-28T15:38:14Z

manifests/copr.pp

+#   }
+#
+define yum::copr (
+  String                                 $repo   = $title,


please add puppet-strings like documentation for the new parameters

Done in the last force-push, really appreciate all the feedback from review, since I'm not yet used to most of the scaffolding and test infrastructure, and you are pushing me to read into the correct things 👍 .

olifre · 2021-06-28T18:17:36Z

I've now fixed the Rubocop offenses in the existing test, and added an acceptance test. I don't have a box at hand (yet) to run the acceptance test, but I think it should work — CI will show ;-).

olifre · 2021-06-28T20:00:16Z

Nice, the acceptance test found a real bug: disableing a COPR repository without adding it first will fail, and not be idempotent on dnf-based systems (which leave the repository file in place, but switch it to disabled in this case). yum-based systems effectively don't differentiate between disabled or removed.

I have fixed that in the last force-push by ensuring a COPR repository is added before disabling it, if disabled is requested and it is not disabled yet on dnf-based systems.

Another issue was that the removed acceptance test did not add a repository first, so it was not a real test whether the removing worked. This is now also fixed.

So I hope this might be the last iteration :-).

traylenator · 2021-06-29T08:09:58Z

One of the problems with this if you are running with

resources{'yumrepo':
   purge => true,
}

The repo file will be deleted won't it?

I don't see a good way around that.

olifre · 2021-06-29T12:01:35Z

The repo file will be deleted won't it?

Indeed...

I don't see a good way around that.

Same here, at least not as long as we want to use the official way (via dnf / yum) instead of managing the repo "manually", but then all the magic hidden by the underlying package manager plugins is lost and we'd need to follow all updates on that end.

Good ideas are very welcome.

olifre · 2023-02-08T01:03:01Z

Sorry for the multiple force-pushes, I found a small logic issue in the last commit and fixed it — if there is any good proposal on how to upstream this, fixing / documenting the issue @traylenator pointed out, please let me know.

bastelfreak · 2023-02-08T08:52:40Z

@olifre force pushes are fine. Can you take a look at the failing CI jobs?

olifre · 2023-02-08T19:55:53Z

@olifre force pushes are fine. Can you take a look at the failing CI jobs?

Thanls, I think I fixed all CI issues, the remaining issue seems to be a fluke of the GitHub actions runner (read timeout reached). I will trigger CI once more with an empty force-push.

olifre · 2023-02-08T20:03:08Z

@bastelfreak That did the trick, now all is green 😄 .

olifre · 2023-02-10T14:46:55Z

@bastelfreak It seems CI went red again after you re-ran it yesterday, but checking the logs, that seems like an issue with the runners, correct?

traylenator · 2023-05-24T19:37:20Z

One of the problems with this if you are running with
resources{'yumrepo':
   purge => true,
}
The repo file will be deleted won't it?

I don't see a good way around that.

Given there's no sensible way around this and it only affects particular configurations I would just document it.
If the resources declaration can be adjusted to ignore the copr repos based on name or something then makes sense to give that example.

https://forge.puppet.com/modules/crayfishx/purge/readme gives an example in fact.

olifre · 2023-05-29T17:04:54Z

Given there's no sensible way around this and it only affects particular configurations I would just document it.
If the resources declaration can be adjusted to ignore the copr repos based on name or something then makes sense to give that example.

Thanks for confirming!

The names of yumrepo resources resulting from COPR commands end up being formed such as:
copr:copr.fedorainfracloud.org:jdoss:wireguard
copr:copr.fedorainfracloud.org:copart:restic
(tested with RHEL 7 and 8). Since resources itself does not seem to allow limiting what is purged, the only way out seems to be to use something like the purge module you linked.

What do you think about the documentation addendum I added in the preceding commit?

olifre · 2023-06-25T18:06:23Z

I have finally come around to also regenerate REFERENCE.md and rebase onto current master, so things should now be green and mergable.

bastelfreak · 2023-06-25T18:50:24Z

manifests/copr.pp

+    'dnf'   => 'dnf-plugins-core',
+    default => 'yum-plugin-copr',
+  }
+  stdlib::ensure_packages([$prereq_plugin])


please introduce a new param like $manage_prereq_plugin and wrap an if condition around thr function.

That makes a lot of sense, done and force-pushed.

COPR (Cool Other Package Repo) is a Fedora project for third-party package repositories.

traylenator reviewed Jun 28, 2021

View reviewed changes

olifre force-pushed the add-copr-support branch from 2874921 to 6004680 Compare June 28, 2021 14:18

bastelfreak reviewed Jun 28, 2021

View reviewed changes

bastelfreak added the enhancement New feature or request label Jun 28, 2021

olifre force-pushed the add-copr-support branch 2 times, most recently from b152e50 to 5a4360b Compare June 28, 2021 18:15

olifre force-pushed the add-copr-support branch from 5a4360b to 5bee058 Compare June 28, 2021 20:00

olifre mentioned this pull request Oct 2, 2022

params: Add support for Rocky Linux. spacedog/puppet-wireguard#43

Open

olifre force-pushed the add-copr-support branch 3 times, most recently from 31033d7 to 8db4120 Compare February 8, 2023 01:02

olifre force-pushed the add-copr-support branch 2 times, most recently from 792e781 to d1902a1 Compare February 8, 2023 19:30

olifre force-pushed the add-copr-support branch from d1902a1 to 04316a8 Compare February 8, 2023 19:56

olifre force-pushed the add-copr-support branch 2 times, most recently from 0675c06 to 5da2f01 Compare June 25, 2023 18:04

olifre force-pushed the add-copr-support branch from 5da2f01 to 97286be Compare June 25, 2023 18:12

bastelfreak reviewed Jun 25, 2023

View reviewed changes

olifre added 5 commits June 25, 2023 20:59

Add yum::copr resource to handle COPR repositories.

04fa3ec

COPR (Cool Other Package Repo) is a Fedora project for third-party package repositories.

README: Note how to prevent COPR yumrepos from being purged.

b88c142

yum::copr: use puppet-strings

e26bac2

Regenerate REFERENCE.md.

903ebac

yum::copr: add manage_prereq_plugin parameter

3f1d236

olifre force-pushed the add-copr-support branch from 97286be to 3f1d236 Compare June 25, 2023 18:59

bastelfreak merged commit 6822a42 into voxpupuli:master Jun 26, 2023

olifre deleted the add-copr-support branch June 26, 2023 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add yum::copr resource to handle COPR repositories. #215

Add yum::copr resource to handle COPR repositories. #215

olifre commented Jun 10, 2021

traylenator left a comment

traylenator Jun 28, 2021

olifre Jun 28, 2021

traylenator Jun 28, 2021

olifre Jun 28, 2021

olifre commented Jun 28, 2021

bastelfreak Jun 28, 2021

olifre Jun 28, 2021

olifre commented Jun 28, 2021

olifre commented Jun 28, 2021 •

edited

Loading

traylenator commented Jun 29, 2021

olifre commented Jun 29, 2021

olifre commented Feb 8, 2023

bastelfreak commented Feb 8, 2023

olifre commented Feb 8, 2023

olifre commented Feb 8, 2023

olifre commented Feb 10, 2023

traylenator commented May 24, 2023 •

edited

Loading

olifre commented May 29, 2023 •

edited

Loading

olifre commented Jun 25, 2023

bastelfreak Jun 25, 2023

olifre Jun 25, 2023

Add yum::copr resource to handle COPR repositories. #215

Add yum::copr resource to handle COPR repositories. #215

Conversation

olifre commented Jun 10, 2021

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

traylenator left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olifre commented Jun 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olifre commented Jun 28, 2021

olifre commented Jun 28, 2021 • edited Loading

traylenator commented Jun 29, 2021

olifre commented Jun 29, 2021

olifre commented Feb 8, 2023

bastelfreak commented Feb 8, 2023

olifre commented Feb 8, 2023

olifre commented Feb 8, 2023

olifre commented Feb 10, 2023

traylenator commented May 24, 2023 • edited Loading

olifre commented May 29, 2023 • edited Loading

olifre commented Jun 25, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olifre commented Jun 28, 2021 •

edited

Loading

traylenator commented May 24, 2023 •

edited

Loading

olifre commented May 29, 2023 •

edited

Loading