modulesync 3.0.0 & puppet-lint updates #188
Conversation
| @@ -34,7 +34,7 @@ function yum::bool2num_hash_recursive($arg) { | |||
| Hash => yum::bool2num_hash_recursive($value), | |||
| default => $value, | |||
| } | |||
| Hash({ $key => $return_value }) | |||
| Hash( { $key => $return_value }) | |||
There was a problem hiding this comment.
This one looks odd. Why is Hash() needed in he first place? I think the whole map can be removed and put in the reduce.
There was a problem hiding this comment.
I took a stab at it, but couldn't get rid of it. This does suggest a bug in the strict linting. If it at least also allowed a space at the end it would at least be symmetrical, but now it isn't.
There was a problem hiding this comment.
I raised voxpupuli/puppet-lint-manifest_whitespace-check#8 for this. Should we continue and merge this as is?. Because the PR fixes some gemfile dependencies.
There was a problem hiding this comment.
We should definitely merge it. A linting issue shouldn't hold up fixes.
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
| @@ -34,7 +34,7 @@ function yum::bool2num_hash_recursive($arg) { | |||
| Hash => yum::bool2num_hash_recursive($value), | |||
| default => $value, | |||
| } | |||
| Hash({ $key => $return_value }) | |||
| Hash( { $key => $return_value }) | |||
There was a problem hiding this comment.
We should definitely merge it. A linting issue shouldn't hold up fixes.
modulesync 3.0.0