Add support for AlmaLinux 8 #203
Conversation
|
Is anyone able to help me fix the tests? I'm not very familiar with Travis-CI |
|
@tparkercbn can you please rebase that to latest master branch |
tparkercbn
force-pushed
the
AlmaLinux-support
branch
from
744078c
to
eee220b
Compare
Done I think! :) Tom |
metadata.json
Outdated
| @@ -70,6 +70,19 @@ | |||
| "operatingsystemrelease": [ | |||
| "2017" | |||
| ] | |||
| }, | |||
| { | |||
| "operatingsystem": "Fedora", | |||
There was a problem hiding this comment.
is that a leftover from the rebase or did you add Fedora on purpose?
|
Leftover. Let me clean that up.
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Tim Meusel ***@***.***>
Sent: Wednesday, June 9, 2021 11:06:50 AM
To: voxpupuli/puppet-yum ***@***.***>
Cc: Tom Parker ***@***.***>; Mention ***@***.***>
Subject: Re: [voxpupuli/puppet-yum] Added support for AlmaLinux 8 (#203)
CAUTION: This email originated from outside your organization. Exercise caution when opening attachments or on clicking links from unknown senders.
@bastelfreak commented on this pull request.
________________________________
In metadata.json<#203 (comment)>:
@@ -70,6 +70,19 @@
"operatingsystemrelease": [
"2017"
]
+ },
+ {
+ "operatingsystem": "Fedora",
is that a leftover from the rebase or did you add Fedora on purpose?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#203 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABJYF5VYV4VQYZRJC3KACFTTR6NSVANCNFSM45IBGFCA>.
|
tparkercbn
force-pushed
the
AlmaLinux-support
branch
from
eee220b
to
cfea801
Compare
|
Fixed it now. Sorry :) I'm not great with Git. |
|
@tparkercbn can you please take a look at the failing tests? |
@bastelfreak I had asked above if someone can help with them. I have no idea how Travis-CI works. I am contributing code that I need to use for my job to get the modules to work but right now I'm swamped and don't have time to learn Travis and I'm hoping that someone else who is more familiar with this can help me fix them up. Tom |
tparkercbn
force-pushed
the
AlmaLinux-support
branch
from
cfea801
to
f5c166c
Compare
|
I pushed a new commit that may help. I'm just not sure what the consequences are. I set: # rubocop:disable RSpec/RepeatedExample anywhere there was a conflict. |
|
Looks like it worked! |
bastelfreak
changed the title
Pull Request (PR) description
Added support for AlmaLinux 8
This Pull Request (PR) fixes the following issues