Revert #258, which added purge_unmanaged_repos #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method of purging unmanaged yum repo configs does not work. Fixes voxpupuli#285
|
Now do we say this is a bugfix or a breaking change? |
vchepkov
approved these changes
Dec 7, 2022
|
this code never worked, but imho, it's a breaking change |
kenyon
changed the title
|
@kenyon Could we re-add this feature using the proper I'm happy to open a PR if this is something that is wanted (it was before, apparently). |
|
@siegy22 that would be fine with me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method of purging unmanaged yum repo configs does not work. This is because the repo configs are managed by puppetlabs/yumrepo_core as native
yumrepotypes, notfileresources.Fixes #285