Rework "nodes" with datatables. #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 10, 2017 14:28
- Metrics direct access - Better json format (no newlines) - Simplify report_status macro
|
Let's get the 0.3 release out then for 0.4 drop python 2.6 and puppetdb 3 |
|
@mterzo can you please have a look at this? |
|
If this works, it could be a solution to #567, but in my testing, I get error after error - I suspect it needs an update for some new version of |
|
I think that we can safely drop PuppetDB 3.x support. It’s unsupported since 2018, IIRC. |
|
closing as the dependent merge is closed and as said no need to support puppetdb3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will need voxpupuli/pypuppetdb#116 to work.
Worked on this for personal use. Fine on my side, but may need improvements or clarity.
A lot of lines refers to puppetdb 3.X inability to provide a consistent "Node" status on "noop" runs. This might be simplified by dropping 3.X support. By the meantime, this PR contains compatibility functions.
For information, this also include a fix for @phybros latest input (report.metrics == None).