Structured fact values as shown as pretty-printed, colored JSON + some bugs fixed #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 22, 2021
Closed
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
==========================================
+ Coverage 80.87% 80.97% +0.09%
==========================================
Files 12 12
Lines 889 883 -6
==========================================
- Hits 719 715 -4
+ Misses 170 168 -2
Continue to review full report at Codecov.
|
sebastianrakel
approved these changes
Nov 28, 2021
|
some of the commits here don't prepare the release but fix bugs or add features. Can you please provide those as dedicated PRs? |
gdubicki
changed the title
bastelfreak
reviewed
Nov 29, 2021
and extend the width of the fact values column in the node view as the values are usually longer that the names. Thus this implements #83. Also fix getting nodes with non-string fact values (#612): Examples: * int (in this case the filtering did not occur at all and ALL results were returned), * list of dict (here the filtering was not done and ZERO results were returned), As showing fact values does not use the code that strips trailing 'u' anymore, this also fixes #567.
gdubicki
changed the title
bastelfreak
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#643 + #644
Fixes #612 and #567 and (I think that) it implements #83.
Here's a screenshot of how will the complex facts look: #644 (comment)