Skip to content

Commit

Permalink
(feat) - Add merge_facts option
Browse files Browse the repository at this point in the history
This commit adds an option to the add_custom_fact method, which allows
the user to specify whether they wish to deep_merge facts.

This allows the user to determine whether they wish to completely
overwrite a fact, or simply merge values into the existing fact in a
given fact hash.
  • Loading branch information
jordanbreen28 committed Feb 1, 2024
1 parent 9cba69c commit 57b22e2
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 1 deletion.
22 changes: 22 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,28 @@ To do this, pass a lambda as the value for the custom fact. The lambda is passed
add_custom_fact :root_home, lambda { |os,facts| "/tmp/#{facts['hostname']}" }
```

#### Merge into existing facts

You can also supply an optional input `:merge_facts` to the `add_custom_fact` method.

This allows you to merge facts values into a fact, if the fact is already present in the facts hash as oppose to overwriting the fact value.

```ruby
add_custom_fact :identity, { 'user' => 'test_user' }, :merge_facts => true
```

Will result in a hash of the identity fact like the below:

```ruby
{
"gid"=>0,
"group"=>"root",
"privileged"=>true,
"uid"=>0,
"user"=>"test_user"
}
```

### Supplying Custom External Facts through FacterDB
Rspec-puppet-facts uses a gem called facterdb that contains many fact sets of various combinations that are pre generated. Rspec-puppet-facts queries
facterdb to pull out a specific fact set to use when testing.
Expand Down
8 changes: 7 additions & 1 deletion lib/rspec-puppet-facts.rb
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,13 @@ def self.with_custom_facts(os, facts)
next if fact[:options][:confine] && !fact[:options][:confine].include?(os)
next if fact[:options][:exclude] && fact[:options][:exclude].include?(os)

facts[name] = fact[:value].respond_to?(:call) ? fact[:value].call(os, facts) : fact[:value]
value = fact[:value].respond_to?(:call) ? fact[:value].call(os, facts) : fact[:value]
# if merge_facts passed, merge supplied facts into facts hash
if fact[:options][:merge_facts]
facts.deep_merge!({name => value})
else
facts[name] = value
end
end

facts
Expand Down

0 comments on commit 57b22e2

Please sign in to comment.