Rely on modern facts #178
Merged
Rely on modern facts #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it read legacy facts, which are deprecated and slowly going away. It drops all the various hacks that were needed for older versions on the assumption they're no longer needed. Facter 2.4 introduced the structured os fact while Facter 3.0 added the os.hardware fact to it. rspec-puppet-facts relies on those, so Facter versions older than 3.0 are no longer supported.
ekohl
force-pushed
the
rely-on-modern-facts
branch
from
4dd3d37
to
b0085f7
Compare
bastelfreak
approved these changes
Jun 9, 2024
ekohl
commented
Jun 9, 2024
Comment on lines
+148
to
151
| unless os_fact | ||
| RspecPuppetFacts.warning "No os fact was found in FacterDB for: #{facts}" | ||
| next | ||
| end |
There was a problem hiding this comment.
This may never show up, but I felt like it was a decent safeguard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it read legacy facts, which are deprecated and slowly going away. It drops all the various hacks that were needed for older versions on the assumption they're no longer needed.
Facter 2.4 introduced the structured os fact while Facter 3.0 added the os.hardware fact to it. rspec-puppet-facts relies on those, so Facter versions older than 3.0 are no longer supported.
It also drops workarounds for Facter < 3.4 on Windows.