Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for SOAP 1.2 Envelope Headers in the server side #1003

Merged
merged 2 commits into from
Mar 23, 2018

Conversation

cazzer
Copy link
Contributor

@cazzer cazzer commented Mar 21, 2018

Currently, forceSoap12Headers only changes the headers which the client sends; the server still returns a SOAP 1.1 envelope definition from the server.

With this pull request, the envelope definition now keys off of the forceSoap12Headers option.

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage increased (+0.003%) to 93.59% when pulling 6b9b9bf on Volta-Charging:master into 7a5550a on vpulim:master.

@herom
Copy link
Contributor

herom commented Mar 23, 2018

Thanks a lot @cazzer 👍

@herom herom merged commit bcc41e6 into vpulim:master Mar 23, 2018
@cazzer
Copy link
Contributor Author

cazzer commented Mar 26, 2018

@herom Should I create another PR to release a new version of this package or will it be released at a regular interval? I am still depending on my fork in a project and would like to revert to depending on soap when this change is released.

@herom
Copy link
Contributor

herom commented Mar 28, 2018

@cazzer Unfortunately we don't have a regular interval to release new versions. It's all pretty loose on this end, but most of the time @jsdevel took the time to release a new version.

I'm sure we'll be able to release a new version very soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants