Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update types to make options optional for createClientAsync #1068

Merged
merged 1 commit into from
May 20, 2019
Merged

Update types to make options optional for createClientAsync #1068

merged 1 commit into from
May 20, 2019

Conversation

GhosalkarPratik
Copy link
Contributor

When I tried creating a client in TS with promises using createClientAsync it gives an error saying it expects at least 2 parameters. Also the readme.md has an example with just url but no options parameter.
Hence making options parameter in createClientAsync optional in soap.ts.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.33% when pulling 2a6252f on GhosalkarPratik:Make_options_optional_in_createClientAsync into f7e2efc on vpulim:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.33% when pulling 2a6252f on GhosalkarPratik:Make_options_optional_in_createClientAsync into f7e2efc on vpulim:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.33% when pulling 2a6252f on GhosalkarPratik:Make_options_optional_in_createClientAsync into f7e2efc on vpulim:master.

@jsdevel jsdevel merged commit f644c3f into vpulim:master May 20, 2019
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Sep 24, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 3, 2019
Closed
Danail-Irinkov pushed a commit to Danail-Irinkov/node-soap that referenced this pull request Jan 19, 2020
@GhosalkarPratik @Danail-Irinkov
Update types to make options optional for createClientAsync (vpulim…
a855774 
…#1068)
@snyk-bot snyk-bot mentioned this pull request Mar 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GhosalkarPratik @coveralls @jsdevel