Expose the WSDL class #1071
Merged
Expose the WSDL class #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is not a documented use case, the WSDL class can be used directly to (de-)serialize XML. This enables users to use an SOAP endpoint that does not expose bindings in the WSDL.
|
@ties this looks good. can you add documentation in the README? |
|
I added documentation in the readme. I do not know the project very well - I'm confident the example code works (it's modeled after my real usage), however it is probably useful if you double check that my interpretation of the functionality is correct. The usage of |
|
thanks! |
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
* Exposes the WSDL class While it is not a documented use case, the WSDL class can be used directly to (de-)serialize XML. This enables users to use an SOAP endpoint that does not expose bindings in the WSDL. * Document usage of the WSDL class in Readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is not a documented use case, the WSDL class can be used
directly to (de-)serialize XML. This enables users to use an SOAP
endpoint that does not expose bindings in the WSDL.
In my specific use case, the SOAP endpoint is an interface to Microsoft Dynamics with URL's documented in documentation. The service can alledgedly be used directly by
svcutil.exe, but is less idiomatic to consume from python or nodejs.I hope you will consider making the WSDL class part of the public API.