added possibility to add action to content-type header #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbar
suggested changes
Jun 5, 2019
| if (!this.wsdl.options.forceSoap12Headers) { | ||
| if (this.wsdl.options.forceSoap12Headers) { | ||
| headers['Content-Type'] = 'application/soap+xml; charset=utf-8'; | ||
| if (this.wsdl.options.addHeadersAction) { |
There was a problem hiding this comment.
According to specification from https://docs.intersystems.com/latest/csp/docbook/DocBook.UI.Page.cls?KEY=ROBJ_method_soapaction action param should be added within forceSoap12Headers flag, not some additional one as because it is required in 1.2 version
|
thanks! |
jsdevel
requested changes
Jun 5, 2019
| @@ -94,6 +94,8 @@ export interface IWsdlBaseOptions { | |||
| wsdl_options?: { [key: string]: any }; | |||
| /** set proper headers for SOAP v1.2. */ | |||
| forceSoap12Headers?: boolean; | |||
| /** set content type header action for SOAP v1.2 */ | |||
| addHeadersAction?: boolean; | |||
There was a problem hiding this comment.
@gbar can you follow up with a PR to add this to the README please?
There was a problem hiding this comment.
Will add that when I get home. Will create another PR with that
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support to add soapAction to Content-Type header.
For example:
https://docs.intersystems.com/latest/csp/docbook/DocBook.UI.Page.cls?KEY=ROBJ_method_soapaction
It allows to set Content-Type to
'application/soap+xml; charset=utf-8'; action=ActionAdded option param:
addHeadersActionthat allows to turn this on/off.