Update package.json #1085
Merged
Update package.json #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are heavily dependent on this module. Please update the lodash vuln asap |
|
what issue are you having with the current version of lodash? |
|
Prototype pollution in lodash versions <=4.17.11
…On Wed, 24 Jul, 2019, 22:51 Joe Spencer, ***@***.***> wrote:
what issue are you having with the current version of lodash?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1085?email_source=notifications&email_token=AIAWG3JMW4E6KM6OBYYSGGLQBCFRZA5CNFSM4IGQK6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XAZVA#issuecomment-514723028>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIAWG3MX33PDL5G74RRYTITQBCFRZANCNFSM4IGQK6IQ>
.
|
|
Please update the commit message to reflect that you're upgrading lodash for this purpose, and squash your commits into one. |
|
Hi @jsdevel , I had updated the commit message to reflect the purpose of lodash update and squashed the commit . Thanks! |
jsdevel
requested changes
Jul 25, 2019
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "soap", | |||
| "version": "0.28.0", | |||
There was a problem hiding this comment.
Please revert this. We bump the version when we publish.
There was a problem hiding this comment.
Sure. I have reverted the soap version change
…ash version to ^4.17.15 in package.json and package-lock.json
|
Thanks! |
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
…ash version to ^4.17.15 in package.json and package-lock.json (vpulim#1085)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating lodash to ^4.17.15