New XML Signing Options, extra tags to sign and small bug fix #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new Signer Options to add prefix to signature tags added Added new Signer Options to add Attributes to the Signature tag Updated the Readme file Added tests change the join from `/n` to `' '` in client _invoke soapheaders. The new line character stopped the XML from being decoded by a WSE system
|
With regards to the change I made in |
jsdevel
requested changes
Oct 1, 2019
| @@ -864,6 +864,20 @@ WS-Security X509 Certificate support. | |||
| var privateKey = fs.readFileSync(privateKeyPath); | |||
| var publicKey = fs.readFileSync(publicKeyPath); | |||
| var password = ''; // optional password | |||
| var options = { | |||
There was a problem hiding this comment.
can you add comments in this example to explain if these are optional and what they're for etc.?
Added Readme examples for the option added Removed some extra XML tags added from a cut and paste error
|
thanks! |
|
@jsdevel when are you planning on doing the next release? |
|
@LorneCurrie published as 0.30.0 |
Danail-Irinkov
pushed a commit
to Danail-Irinkov/node-soap
that referenced
this pull request
Jan 19, 2020
…#1091) * New XML Signing Options, extra tags to sign and small bug fix Added new Signer Options to add prefix to signature tags added Added new Signer Options to add Attributes to the Signature tag Updated the Readme file Added tests change the join from `/n` to `' '` in client _invoke soapheaders. The new line character stopped the XML from being decoded by a WSE system * Fixed small lint issues * Added README examples Added Readme examples for the option added Removed some extra XML tags added from a cut and paste error
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new Signer Options to add a prefix to the signature tags added in WSSecurityCert
Added new Signer Options to add Attributes to the Signature tag added in WSSecurityCert
Updated the Readme file
Added tests
Change the join from
/nto' 'in client _invoke soapheaders.The new line character stopped the XML from being decoded by a WSE SOAP server