Bug where no prototypical inheritence chain exists #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some transpilers will create objects using `Object.create(null)`. This creates an object with no prototypical inheritence, so no `hasOwnProperty`. The fix is if such an object exists, we use `Object.assign` to copy the prototype from an empty object into the obj. Signed-off-by: NoMan2000 <[email protected]>
|
Is anyone reviewing this? After updating to v0.31.0 this issue broke my app I had to roll back to a previous version. |
|
The fix is dead simple, so I'm guessing that they haven't seen it? |
|
This didn't fix my issue unfortunately. Any null values in the args still causes the request to fail. |
Can you submit some sample code and tag me on it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object.create(null). This creates an object with no prototypical inheritance, so there is nohasOwnPropertymethod on it.The fix is if that if such an object exists, use
Object.assignto copy the prototype chain from an empty object into the null created obj.Otherwise, you just get a TypeError that
obj.hasOwnProperty is not a function.Signed-off-by: NoMan2000 [email protected]