Avoid lodash where possible #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you're killing it @TrySound ! can you rebase onto latest master? |
jsdevel
reviewed
Sep 29, 2020
| @@ -1,5 +1,3 @@ | |||
| var _ = require('lodash'); | |||
There was a problem hiding this comment.
can we remove lodash altogether?
There was a problem hiding this comment.
It's just one module. I will try to cover other cases in upcoming PRs.
Lodash is quote big project and it's required less with a time in modern environments. In this diff I bumped node support to 8+ and used native methods where possible instead of lodash. Later we can go further and completely remove it from the project. This can make the project much smaller. https://packagephobia.com/result?p=soap
TrySound
force-pushed
the
avoid-lodash
branch
from
ef39b72
to
bde066e
Compare
|
@jsdevel Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodash is quote big project and it's required less with a time in modern
environments. In this diff I bumped node support to 8+ and used native
methods where possible instead of lodash. Later we can go further and
completely remove it from the project.
This can make the project much smaller.
https://packagephobia.com/result?p=soap