Drop bluebird #1125
Merged
Drop bluebird #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using bluebird for promisifying is a bit overhead. Especially since the package is quite massive. https://packagephobia.com/result?p=bluebird In this diff I replaced Bluebird.promisifyAll with custom promisifying specifically for services methods instead of all class methods.
TrySound
force-pushed
the
drop-bluebird
branch
from
e49ee4e
to
e36b18a
Compare
|
This pull request broke async methods without parameters. Now I have to pass empty object as workaround. |
|
@Biktop can you submit a pr? |
|
Sorry but I don't think that I'm able to do it. I've just discussed this workaround on gitter and tested it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using bluebird for promisifying is a bit overhead. Especially since the
package is quite massive. https://packagephobia.com/result?p=bluebird
In this diff I replaced Bluebird.promisifyAll with custom promisifying
specifically for services methods instead of all class methods.