Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add handling for extension base without children #1135

Merged
merged 5 commits into from
Feb 11, 2021

Conversation

KnutEdelbert
Copy link
Contributor

When parsing the wsdl, the trace don't recognize the reference in the base attribute of an ExtensionElement without child nodes, when it comes to findChildSchemaObject. It should be handled like the type attribute on ElementElements

@coveralls
Copy link

coveralls commented Jan 21, 2021

Coverage Status

Coverage increased (+0.02%) to 94.925% when pulling ea487fb on KnutEdelbert:master into 1c76a87 on vpulim:master.

@KnutEdelbert
Copy link
Contributor Author

ok, finally, it looks good.
@jsdevel: is there anything else i have to do now?

@jsdevel
Copy link
Collaborator

jsdevel commented Jan 27, 2021

@KnutEdelbert please remove the change to package-lock.json

as @jsdevel said: "please remove the change to package-lock.json". It's done.
@KnutEdelbert
Copy link
Contributor Author

@jsdevel as you wish - it's deleted

@KnutEdelbert
Copy link
Contributor Author

ok, i think it was better to revert the file instead of deleting it....
@jsdevel Everything ok now?

@jsdevel jsdevel merged commit a6ae805 into vpulim:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants