Circular element references inside wsdl - assistance needed #1142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This fix #1101 fixed one bug and introduced another. Now parsing wsdl with recursive ref elements will cause stack overflow. I created 2 test cases which demonstrate this bug, but I need advice of someone who knows this project better than me.
I can quick fix stack overflow with one kludge - just like #1101, something like this, or maybe a little more complex - because second test will fail with this:
As pedantic person, I think kludge is not the way to do. In my opinion main problem is more deep in internals: both element names (with references) and type names go to the same object
definitions.descriptions.types
, they are mixed, and this introduces all these bugs with elements and types, but I'm not sure in this, because I'm new to node-soap internals, I just use it as a regular user.So I need advice from someone, I can try to fix this by splitting
definitions.descriptions.types
for elements and for types, but it seems this is core internal feature, I'm afraid to break something and waste my time making PR which will not be accepted.