Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parameter in example #1172

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Fix missing parameter in example #1172

merged 2 commits into from
Mar 18, 2022

Conversation

dj95
Copy link
Contributor

@dj95 dj95 commented Nov 5, 2021

The example in the README does not include a required parameter. If this parameter is omitted, the client will always be undefined.

@dj95
Copy link
Contributor Author

dj95 commented Feb 8, 2022

Since you do not seem to care about pull requests I'll close this one now...

@dj95 dj95 closed this Feb 8, 2022
@jsdevel
Copy link
Collaborator

jsdevel commented Mar 18, 2022

@dj95 so harsh! please re-open. sorry, i usually go through the open PRs every month or so.

@jsdevel jsdevel reopened this Mar 18, 2022
@jsdevel jsdevel merged commit 99832a1 into vpulim:master Mar 18, 2022
@dj95
Copy link
Contributor Author

dj95 commented Mar 18, 2022

Since there was progress on other issues I thought that you might not care. Sorry for my impatience!

@dj95
Copy link
Contributor Author

dj95 commented Mar 18, 2022

Thank you for reopening and merging the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants