Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly serialize MTOM into axios data and add Content-Encoding: gzip support in soap request #1173

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

ischisan
Copy link
Contributor

No description provided.

@ischisan
Copy link
Contributor Author

content was empty when using MTOM and Content-Lenfth was 0, so i added the logic for serializing the multiparts into the body.

@jsdevel
Copy link
Collaborator

jsdevel commented Nov 12, 2021

please undo all the style changes. i can't even see what you changed with all the whitespace changes...

@ischisan
Copy link
Contributor Author

ischisan commented Nov 12, 2021

please undo all the style changes. i can't even see what you changed with all the whitespace changes...

sorry, prettier was activated ;-)

i have removed the style changes now.

BR

@ischisan
Copy link
Contributor Author

I added support to enforce gzip compression in soap request

@ischisan ischisan changed the title correctly serialize MTOM into axios data correctly serialize MTOM into axios data and add Content-Encoding: gzip support in soap request Nov 13, 2021
Readme.md Outdated Show resolved Hide resolved
Readme.md Outdated Show resolved Hide resolved
@jsdevel
Copy link
Collaborator

jsdevel commented Nov 16, 2021

@ischisan do you have a way of adding a test for this?

@ischisan
Copy link
Contributor Author

ischisan commented Nov 16, 2021

@ischisan do you have a way of adding a test for this?

this is hardly possible since the soap server does not support MTOM. Maybe I can add that server functionality later, but not before next month. I would provide a test for server and client after that.

@jsdevel jsdevel merged commit edfe923 into vpulim:master Nov 16, 2021
@jsdevel
Copy link
Collaborator

jsdevel commented Nov 16, 2021

that would be great if you could follow up when you can @ischisan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants