-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade formidable to v2 #1183
Upgrade formidable to v2 #1183
Conversation
@vpulim ping |
need the build to pass |
The failure doesn't look related to my change. It looks the same as in #1180. |
@orgads i know you didn't cause it. i'm mainly a PR reviewer and publisher. if you have time to fix it on master i'd greatly appreciate it |
v1 is deprecated.
Rebased. Please review. |
The update to this version now breaks our webpack build and accordingly to formidable, updating to version 3 fixes the issue. Is there any reason why you didn't choose to update to version 3 instead? |
I used |
Fair enough, I've followed up with their team to see what's the status. Thanks! |
v1 is deprecated.
v1 is deprecated.