Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade formidable to v2 #1183

Merged
merged 1 commit into from
Jun 15, 2022
Merged

Upgrade formidable to v2 #1183

merged 1 commit into from
Jun 15, 2022

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Mar 15, 2022

v1 is deprecated.

@orgads
Copy link
Contributor Author

orgads commented Mar 27, 2022

@vpulim ping

@jsdevel
Copy link
Collaborator

jsdevel commented Apr 13, 2022

need the build to pass

@orgads
Copy link
Contributor Author

orgads commented Apr 13, 2022

The failure doesn't look related to my change. It looks the same as in #1180.

@jsdevel
Copy link
Collaborator

jsdevel commented Apr 13, 2022

@orgads i know you didn't cause it. i'm mainly a PR reviewer and publisher. if you have time to fix it on master i'd greatly appreciate it

v1 is deprecated.
@orgads
Copy link
Contributor Author

orgads commented Jun 7, 2022

Rebased. Please review.

@jsdevel jsdevel merged commit 0089ce3 into vpulim:master Jun 15, 2022
@orgads orgads deleted the formidable-up branch June 15, 2022 19:11
@alfaproject
Copy link

The update to this version now breaks our webpack build and accordingly to formidable, updating to version 3 fixes the issue. Is there any reason why you didn't choose to update to version 3 instead?

@orgads
Copy link
Contributor Author

orgads commented Jun 26, 2022

I used latest. Wasn't aware of v3 (which is still not latest at this point).

@alfaproject
Copy link

Fair enough, I've followed up with their team to see what's the status. Thanks!

sandrozbinden-axa pushed a commit to axa-health/node-soap that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants