Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed double await in async and fixed response #1185

Merged
merged 2 commits into from
May 18, 2022
Merged

Conversation

anasik
Copy link
Contributor

@anasik anasik commented May 16, 2022

There's no need to call await again on the result object since result is already resolved.

There's no need to call await again on the result object since result is already resolved.
@anasik anasik changed the title Removed double await in async Removed double await in async and fixed response May 16, 2022
In the example for async, logging result returns an array containing not just the JSON response but also the rawResponse, rawRequest e.t.c. 
This can be confusing for users who try the async example after trying the non-async examples which only return the JSON response. 

I added a subscript to the 0th index so that that's what's logged.
@jsdevel jsdevel merged commit 56c7942 into vpulim:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants