Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow WSSecurity and WSSecurityCert to be used together #1195

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Allow WSSecurity and WSSecurityCert to be used together #1195

merged 2 commits into from
Aug 17, 2022

Conversation

flowpl
Copy link
Contributor

@flowpl flowpl commented Aug 10, 2022 •
edited
Loading

This PR changes/adds the following funtionality:

  • a new ISecurity implementation (WSSecurityPlusCert) that takes WSSecurity and WSSecurityCert and combines their results into one SOAP request in case you need to use and at the same time.
  • changes to the WSSecurityCert implementation to enhance an existing header instead of adding another one.
  • replace the static Id="_0" reference on the Body with reference Ids generated by xml-crypto.
  • a new idMode option in WSSecurityCert to control the reference id generation of xml-crypto.

=====

I just realized that the functionality provided here is very close to PR #1187. Just FYI.

@flowpl flowpl changed the title Feat/wssecurity Allow WSSecurity and WSSecurityCert to be used together Aug 10, 2022
@jsdevel jsdevel merged commit ceb2599 into vpulim:master Aug 17, 2022
@flowpl flowpl deleted the feat/wssecurity branch August 29, 2022 12:28
sandrozbinden-axa pushed a commit to axa-health/node-soap that referenced this pull request Oct 6, 2022
@flowpl @sandrozbinden-axa
Allow WSSecurity and WSSecurityCert to be used together (vpulim#1195)
b06b93a 
* feat(WSSecurity): allow using WSSecurity and WSSecurityCert together

* docs: add idMode option for WSSecurityCert to Readme

Co-authored-by: Florian Schmid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flowpl @jsdevel