-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preserve whitespace for space only text node: <text> </text> #1211
Conversation
bea1569
to
36aaea7
Compare
36aaea7
to
fb24c7b
Compare
Could you please add tests for this change? |
18aa31c
to
a1f17a7
Compare
test/response-preserve-whitespace-test.js |
a1f17a7
to
cac9c52
Compare
cac9c52
to
ac26562
Compare
Looks like new test failed, could you please have a look? Thanks. |
both test/client-response-options-test.js test/response-preserve-whitespace-test.js use 'test/wsdl/hello.wsdl' to create soap client. please take a look at the following test.
|
because the assertion in the test case failed, and the following
as i commented yesterday, if you run the single test case, it will passed.
but if you run the following 2 test case together, the second test case will failed.
The reason why the second test case failed is that the two test cases use 'test/wsdl/hello.wsdl' to create soap client. The cur.schema in the following code is different. i don't know why the second soap client is different from the first soap client, this may be another bug. |
I think this is useful change, but working tests are required for that. I am happy to accept this when all tests pass. Thanks. |
Thanks for fixing the test. I will include this in next release. Thanks. |
when preverseWhitespace = true option is specified, the space in the text node should be preversed.
but if the text node's content is all white space, these space is not preserved.
example:
expect: result.text = ' ' (<- one space)
actual: result.text = '' (empty string)