Speed up WSDL parsing #1218
Merged
Speed up WSDL parsing #1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were running into performance issues while generating a SOAP client. I profiled the client generation and identified two bottlenecks in parsing WSDL files: - When visiting an unexpected node an error got constructed that was discarded later on in non-strict mode. Constructing an error is pretty expensive because Node needs to capture the stack. - splitQName split the entire nsName string even though it's only interested in the first element
tomquist
commented
May 4, 2023
| assert.ok(client.lastElapsedTime); | ||
| assert.ok(client.lastElapsedTime !== undefined); |
There was a problem hiding this comment.
This seems to be flaky on my machine because it's 0 sometimes (and more likely with this change), which is falsy. However, we're only interested in the existence of the value.
tomquist
commented
May 4, 2023
Comment on lines
+189
to
+193
| public startElement(stack: Element[], nsName: string, attrs, options: IWsdlBaseOptions, schemaXmlns) { | ||
| const child = new UnexpectedElement(nsName, attrs, options, schemaXmlns); | ||
| child.init(); | ||
| stack.push(child); | ||
| } |
There was a problem hiding this comment.
This short-circuits the allowedChildren lookup.
w666
approved these changes
Apr 26, 2024
|
Changes look good. I guess you run some performance tests, how much faster parsing now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into performance issues while generating a SOAP client. I profiled the client generation and identified two bottlenecks in parsing WSDL files: