Prevent mutating $type in the schema while processing requests #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w666
reviewed
Apr 26, 2024
| assert.deepEqual(err.root, responseJSON); | ||
| } else { | ||
| // assert.deepEqual(json, responseJSON); | ||
| assert.equal(JSON.stringify(typeof json === 'undefined' ? null : json), JSON.stringify(responseJSON)); |
There was a problem hiding this comment.
I am wondering what was the reason to use stringify and equal instead of deepEqueal?
There was a problem hiding this comment.
That's shamelessly copied from the request/response tests...
There was a problem hiding this comment.
Does it work with the deepEqual?
simhnna
force-pushed
the
do-not-change-schema-on-request
branch
from
d9c13e9
to
1c97613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm relying on the wsdl for typechecking and requests mutate
$type.I don't really understand much about the code, but with my change
$typeis no longer changed and all tests still pass.This behavior was introduced with an old commit and I would consider changing the schema during request processing to be a bad habit. Ideally the namespaces would be set initially during schema parsing and not touched later.