Pass the error object to log #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ikonst, Could you please add a test for this? Change looks good me. |
|
@w666 take a look ^ |
ikonst
force-pushed
the
pass-error-to-log
branch
from
4e9d23b
to
35e4a6a
Compare
w666
reviewed
Jul 20, 2024
w666
requested changes
Jul 20, 2024
w666
approved these changes
Jul 21, 2024
w666
approved these changes
Jul 21, 2024
|
Approved, thanks for the improvement, I will include it into next release. Please let me know if you need these changes asap, will see if I can make a release earlier. |
|
Thank you. There's no urgency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code uses
suppressStackto determine what is logged, while I thinksuppressStackwas only intended to control whether we expose internals to the caller.It would be preferable if the logging mechanism could see the original error for what it is, since then it could use the appropriate logging mechanism in the code base; for example, pass the error object to Sentry, or log it in a structured way (name and stack separately) for Datadog to consume, etc.