Feature inform signaturealgorithm #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algorithms can be setted.
w666
reviewed
Sep 10, 2024
This reverts commit 832096d.
reformating entire file
w666
approved these changes
Sep 11, 2024
|
@JoseTM let me know if you need this feature to be released asap, if no I will do at my normal release schedule in 1-2 weeks. |
|
In your normal workflow is fine. Pleased to contribute and thanks for your job |
|
Good to know it's going to be released soon. :D |
|
1.1.4 has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default algorithm seem to be removed from xml-crypto; so now must it must be specified. WSSecurityCert is not setting singnatureAlgorithm actually so just rsa-sha256 is been used. I tried to fix this behaviour to be able of setting signature algorithm.