Configure for v0.12 and io.js compatibility

[andrewbranch]

Fixes #550. Sorry about the end-of-line spacing changes, my editor seemed to do that automatically for some reason.

[mdhooge]

It is no surprise, but this also solves the problem with node 0.12.0.
However, I wonder if this wouldn't be better to explicitly check for "object" instead of an inequality with "string". I could try myself, but right now, I'm back to v0.10.36 ;-)

[herom]

Thanks a lot for your contribution @andrewbranch - we appreciate it a lot! This really should make it into a new release as soon as possible 👍

Before we can merge this, I'll have to ask you to revert all unnecessary changes (like the end-of-line changes, etc.) so that we can keep our Git History clean and don't clutter it with changes which shouldn't be in history (the history should show only real code changes, nothing more).

Also, I guess it would be of further value, if you could add a line in our .travis.yml file to include node v0.12.0 for testing along with your commit. If you do so, please amend and force push, or squash and force push your changes as we request 1 commit per PR as stated in our Guidelines for Submitting a Pull Request.

[andrewbranch]

@mdhooge — I agree; changed to object.
@herom — I’m not sure how to overwrite commits I already pushed to GitHub. You can see that what I just tried kind of made things messier—my apologies. Would it be easiest to delete this PR and start a fresh one? Sorry for the inconvenience.

[andrewbranch]

Fixed the commit history, but it looks like there are other issues arising with newer node versions. Working on adding fixes to the pull.

[andrewbranch]

Most of the failing tests from the last build were caused by server.address().address() returning ::. I have no idea what that’s about, but I checked for it and replaced with 127.0.0.1. However, there are still two failing tests that I don’t know how to fix. Would appreciate help from someone more familiar with the project.

[robertjneal]

It looks like you can fix the error by copying the conditional you used in server-test.js to the beforeEach of ssl-test.js, namely:
if (test.server.address().address === '0.0.0.0' || test.server.address().address === '::') {

I didn't checkout your branch to confirm, but that looks to be the issue.

[andrewbranch]

Everything looks good now! Thanks to @mdhooge, @herom, and @robertjneal for the input/guidance!

[herom]

why was this removed?

[andrewbranch]

Only an addition is shown here—the dashes are part of the YAML syntax itself. :)

[simonjosefsson]

On a tangential note, is there a specific reason to stay with [email protected]?
It's almost a year old and npm's current requirement of node >= 0.8 seems like a non-issue no?

[herom]

@andrewbranch oh, sorry - I was totally shure that this was deleted 😸

@simonjosefsson we needed npm v1.4.6 in order to let the tests pass for node v0.8.0 too while pulling in some new libraries. This could probably make it into another PR where we should discuss about support for the (very, very) old node v0.8.0 in general.

[herom]

Thanks a ton @andrewbranch 👯

[andrewbranch]

@herom My pleasure—one step closer to using io.js on Heroku!