Fix broken options variable in client SOAP requests #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Odd. Not sure why this didn't build. It runs perfectly on my local machine... Hrmm... |
|
please add tests |
Create tests and ensure all tests run successfully Fix typographical errors created due to odd merge
|
Added tests. All tests pass except for the first two. Odd. EDIT: Nevermind. That must have just been my local system. Looks like all tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The options variable was not registering in client SOAP requests, regardless of its contents. I modified the client.js file to include some items from wsdl.js, and it automagically worked the way it was supposed to. I suspect there might be a broken link to the WSDL class in the Client class that caused this, but I cannot tell for certain. Perhaps someone with more experience with this library could investigate further?
Thanks!
Jesse