-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better error handling for missing SOAP elements #869
Conversation
assert.equal(body.indexOf('Failed to parse the SOAP Message body') !== -1, true); | ||
done(); | ||
}); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no empty line between blocks
1 similar comment
@jsdevel have removed the empty line and squashed the commits into one. |
Thanks @prasunsultania ! See my other comments. |
@jsdevel have made changes by removing all empty lines as suggested. PLMK if it looks good. Strange that Is their a way to re-run the build check, as the build failed only for node.js 4 and does't seems to be an error with code or test cases ? |
tests are failing. Can you fix them? |
Ahh, I see. I kicked off the failed job again. Hopefully it passes. |
@jsdevel it did pass :) |
\o/ |
Thanks a ton @prasunsultania ! |
Better error handling to speed up debugging: