Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception 'Parameter 'url' must be a string, not object' #870

Merged
merged 5 commits into from Oct 20, 2016
Merged

Fix exception 'Parameter 'url' must be a string, not object' #870

merged 5 commits into from Oct 20, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 12, 2016

No description provided.

@coveralls
Copy link

coveralls commented Aug 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.528% when pulling 252bc47 on iuriibesedin:master into afc2222 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Aug 12, 2016

can you add a test?

@ghost
Copy link
Author

ghost commented Sep 26, 2016

I've added the test.

@coveralls
Copy link

coveralls commented Sep 26, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 92.715% when pulling ecb0cab on iuriibesedin:master into afc2222 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Sep 26, 2016

Thanks! Looks like there's a conflicting file. Can you git pull --rebase upstream master?

@ghost
Copy link
Author

ghost commented Sep 27, 2016

Done, can you check?

@coveralls
Copy link

coveralls commented Sep 27, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.715% when pulling 05ae693 on iuriibesedin:master into e9254eb on vpulim:master.

@coveralls
Copy link

coveralls commented Sep 27, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 92.715% when pulling 05ae693 on iuriibesedin:master into e9254eb on vpulim:master.

@ghost
Copy link
Author

ghost commented Oct 20, 2016

When will you be able to merge this fix to master?

@jsdevel jsdevel merged commit 89c8864 into vpulim:master Oct 20, 2016
@jsdevel
Copy link
Collaborator

jsdevel commented Oct 20, 2016

Thanks @iuriibesedin !

@ghost
Copy link
Author

ghost commented Nov 2, 2016

when are you going to release last fixes to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coveralls @jsdevel