When SOAP Body is returned blank <soap:body/>, there were failures in… #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @vidishdatta. One minor comment then I think we're good to go. |
jsdevel
reviewed
Oct 18, 2016
| }); | ||
| }, baseUrl); | ||
| }); | ||
|
|
There was a problem hiding this comment.
please remove this empty line.
|
Thanks @vidishdatta ! |
|
Hi @jsdevel , Thanks for accepting changes. This is my first contribution to open source. Just wanted to understand - When do we usually release it to NPM registry and when do we usually create a release for this repository? Thanks Again! |
|
We usually get to releases every 2 weeks or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SOAP Body is returned blank soap:body/, there were failures in processing it.