Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the possibility to use our own exchangeId #907

Merged
merged 2 commits into from
Dec 15, 2016

Conversation

rflament
Copy link
Contributor

This pull request adds the possibility to pass your own exchange id in each request instead of letting node-soap generating it.

This is useful in case your code already have one, for example if your server code receives requests that contain an exchangeId, and you want to use it in node-soap.

@rflament rflament changed the title add the possibility to use our own exchangdId add the possibility to use our own exchangeId Dec 15, 2016
@herom
Copy link
Contributor

herom commented Dec 15, 2016

Thanks a lot for your contribution @rflament - could you please add a test (as required in our CONTRIBUTION Guidelines on Submitting a Pull Request) ?

@coveralls
Copy link

coveralls commented Dec 15, 2016

Coverage Status

Coverage remained the same at 93.151% when pulling 9f5e050 on rflament:custom-exchangeId into 1a90a02 on vpulim:master.

@rflament
Copy link
Contributor Author

done.
should I squash the commits too ?

@herom herom merged commit b4651cc into vpulim:master Dec 15, 2016
@herom
Copy link
Contributor

herom commented Dec 15, 2016

thanks 👍

Since it's possible to squash&merge in github directly, it's not necessary to squash 'em 👯‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants