Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to alter xml before sent #943

Merged
merged 5 commits into from
Jun 27, 2017
Merged

Add ability to alter xml before sent #943

merged 5 commits into from
Jun 27, 2017

Conversation

rafal83
Copy link
Contributor

@rafal83 rafal83 commented Jun 23, 2017

add to option "postProcess" to add ability to alter xml before sent

add to option "postProcess" to add ability to alter xml before sent
@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-0.04%) to 93.229% when pulling 2aab8f4 on rafal83:patch-1 into 41982c1 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Jun 23, 2017

Please add a sample to the tests and update the readme

rafal83 added a commit to rafal83/node-soap that referenced this pull request Jun 25, 2017
Add ability to alter xml before sent vpulim#943
@herom
Copy link
Contributor

herom commented Jun 26, 2017

@rafal83 thanks a lot for your contribution 👍 - I think what @jsdevel wanted to tell was to add tests & update the readme within this very PR, but I'm glad to merge in your PRs if you could please give them proper titles. These titles will help us when merging as well as when we're creating the CHANGELOG.md 😸

Please rename your PRs and add a short description of their content (e.g. Tests, Update Documentation) and we're good to go 🚀

@jsdevel are you ok if we take this merge order?:

  1. Test (failing node-soap when merged)
  2. Implementation (fixes failing test)
  3. Documentation

@jsdevel
Copy link
Collaborator

jsdevel commented Jun 26, 2017

@jsdevel are you ok if we take this merge order?:

I'd prefer if the other PRs were merged into this one. That way when we merge it's easier to track in History.md etc.

@herom
Copy link
Contributor

herom commented Jun 26, 2017

I'd prefer if the other PRs were merged into this one. That way when we merge it's easier to track in History.md etc.

Agreed - this would definitely make it a lot easier 💯

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-0.04%) to 93.229% when pulling e239a70 on rafal83:patch-1 into 41982c1 on vpulim:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-78.7%) to 14.553% when pulling 50351af on rafal83:patch-1 into 41982c1 on vpulim:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.007%) to 93.279% when pulling 2367a2c on rafal83:patch-1 into 41982c1 on vpulim:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.007%) to 93.279% when pulling 2c8743d on rafal83:patch-1 into 41982c1 on vpulim:master.

@herom herom merged commit 599c925 into vpulim:master Jun 27, 2017
@herom
Copy link
Contributor

herom commented Jun 27, 2017

thanks a ton @rafal83 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants