only detect xsi:nil if its value is true
#983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wvanderdeijl This is great! Can you remove |
wvanderdeijl
force-pushed
the
xsi-nil
branch
from
74a390e
to
9cc9ec5
Compare
|
oops. I missed your comment. Just removed the package-lock so this PR should be good to go |
|
Lame. Looks like npm doesn't support node version
Going to merge this PR anyway as the other builds passed. Thanks for the contribution @wvanderdeijl ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we had an example where the SOAP service outputs xml with
xsi:nil="false"which was interpreted by node-soap as having a xsi:nil attribute and thus removing the element from the response. This PR makes the check more strict and verifies that xsi:nil is actually true