add option to remove element-by-element namespacing of json arrays #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me (cc @herom). @snburkett can you add a note in the |
herom
reviewed
Jan 8, 2018
lib/wsdl.js
Outdated
| if (options.namespaceArrayElements !== undefined) { | ||
| this.options.namespaceArrayElements = options.namespaceArrayElements; | ||
| } | ||
| else { |
There was a problem hiding this comment.
could you please move the else up, so that it's in line with the closing brace of the if condition (} else {)?
lib/wsdl.js
Outdated
| @@ -1718,9 +1725,13 @@ WSDL.prototype.objectToXML = function(obj, name, nsPrefix, nsURI, isFirst, xmlns | |||
| parts.push(openingTagParts.join('')); | |||
| } else { | |||
| openingTagParts.push('>'); | |||
| parts.push(openingTagParts.join('')); | |||
| if(self.options.namespaceArrayElements || i == 0) { | |||
There was a problem hiding this comment.
Please just use the "typesafe" operator === only
lib/wsdl.js
Outdated
| parts.push(body); | ||
| parts.push(['</', appendColon(correctOuterNsPrefix), name, '>'].join('')); | ||
| if(self.options.namespaceArrayElements || i == n-1) { |
There was a problem hiding this comment.
The same as above, please just use ===
add tests for array element namespacing options
snburkett
force-pushed
the
arrayElementNamespacing
branch
from
717aafd
to
8c995c7
Compare
|
Readme updated and code style changes made. Squashed/forced into the original commit. Please let me know if you need anything else. Thank you! |
|
Thanks a ton @snburkett 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the wsdl marshalling code converts JSON arrays of the form:
{ PeriodList: { PeriodType: [ {PeriodId: '1'}, {PeriodId: '2'} ] } }Into xml documents of the form
<PeriodList> <PeriodType><PeriodId>1</PeriodId></PeriodType><PeriodType><PeriodId>2</PeriodId></PeriodType></PeriodList>However, certain web services are unable to correctly recognize that the various "PeriodType" elements are intended to be part of the same array, resulting in the unmarshalling:
{ PeriodList: [ PeriodType: [ {PeriodId: '1'} ], PeriodType: [ {PeriodId: '2'} ] ] }To remedy this, a new client/wsdl option "namespaceArrayElements" has been added. The default (true) is the current behavior. If namespaceArrayElements is set to false, however, the following xml will be generated, which allows for correct array construction on the server side:
<PeriodList><PeriodType><PeriodId>1</PeriodId><PeriodId>2</PeriodId></PeriodType></PeriodList>