Fix/update spec from tests #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could add Constants from getConfig I think. Edit: maybe the reporting reasons too? |
ariesclark
requested changes
Sep 28, 2024
ariesclark
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoints/changes I've not included here:
https://github.com/vrchatapi/specification-test/blob/main/data/requests/economy/getsteamtransactions.md because it needs oneOf (empty string vs object)
https://github.com/vrchatapi/specification-test/blob/main/data/requests/permissions/getassignedpermissions.md i did all but the data ones since that is arbitrary I think
https://github.com/vrchatapi/specification-test/blob/main/data/requests/system/getjavascript.md because JS
https://github.com/vrchatapi/specification-test/blob/main/data/requests/system/getcss.md because CSS
https://github.com/vrchatapi/specification-test/blob/main/data/requests/system/getinfopush-with-user-all.md because lol
https://github.com/vrchatapi/specification-test/blob/main/data/requests/system/getconfig.md because it's highly unstable and half of these are already outdated
notes:
https://github.com/vrchatapi/specification-test/blob/main/data/requests/groups/getgroup.md i've set as a list of string since it returns [] and I have no idea what that could be