Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default value to doc_type in index method as it is by default set to '_doc' #27

Merged
merged 2 commits into from
Oct 6, 2019
Merged

Add default value to doc_type in index method as it is by default set to '_doc' #27

merged 2 commits into from
Oct 6, 2019

Conversation

mohantyashish109
Copy link
Contributor

@mohantyashish109 mohantyashish109 commented Sep 30, 2019 •
edited
Loading

Add default value to doc_type in index method as it is by default set to '_doc', as while mocking with es 7.x it fails if we do not add the doc type specifically when calling the index method with the index mock to accept doc_type by default to _doc as with elastic search 7.x the value is set to _doc by default, and when mocking the index method we do have to pass the doc_type as mandatory

#26

@mohantyashish109
Add default value to doc_type in index method as it is by default set…
f56ec6a 
… to '_doc',

as while mocking with es 7.x it fails if we do not add the doc type specifically
when calling the index method with the index mock to accept doc_type by default
to _doc as with elastic search 7.x the value is set to _doc by default,
and when mocking the index method we do have to pass the doc_type as mandatory
@coveralls
Copy link

coveralls commented Sep 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 98.83% when pulling e576f2c on mohantyashish109:fix_index_mock_for_es7 into 987f8c0 on vrcmarcos:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 98.538% when pulling f56ec6a on mohantyashish109:fix_index_mock_for_es7 into 987f8c0 on vrcmarcos:master.

@mohantyashish109 mohantyashish109 changed the title Add default value to doc_type in index method as it is by default set… Add default value to doc_type in index method as it is by default set to '_doc' Oct 1, 2019
@vrcmarcos vrcmarcos merged commit 4df0f86 into vrcmarcos:master Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohantyashish109 @coveralls @vrcmarcos