Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test filter #1288

Merged
merged 2 commits into from
Oct 11, 2021
Merged

Fix/test filter #1288

merged 2 commits into from
Oct 11, 2021

Conversation

ousttrue
Copy link
Contributor

unit test 修正。

Mesh Filter の Export でヒットするケースがあった

#1283 と関連かな

@@ -201,9 +201,12 @@ public MeshExportInfo(Renderer renderer, GltfExportSettings settings)
else if (renderer is MeshRenderer mr)
{
var filter = mr.GetComponent<MeshFilter>();
if (filter.hideFlags == HideFlags.None && Mesh.vertexCount > 0 && filter != null)
if (filter != null && filter.hideFlags == HideFlags.None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null チェックが先(それはそうですね)

@ousttrue ousttrue merged commit 3ca3459 into vrm-c:master Oct 11, 2021
@ousttrue ousttrue deleted the fix/test_filter branch October 27, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants