Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo (Base64Embedded) #280

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

saturday06
Copy link
Contributor

@saturday06 saturday06 commented Jun 8, 2019

glTFインポート時に自動命名されるテクスチャー名のtypoを修正しました。仕様変更になります。いちおう修正PRとして出しましたが、テクスチャー名を使って何か処理をしているプログラムが想定される場合はそのままのほうが安全かもしれません。

@hiroj
Copy link
Contributor

hiroj commented Jun 25, 2019

どれぐらい影響がありそうか検討します

@hiroj
Copy link
Contributor

hiroj commented Dec 13, 2019

ほぼ影響が無いためマージします

@hiroj hiroj merged commit 58e2085 into vrm-c:master Dec 13, 2019
@saturday06 saturday06 deleted the fix/typo_embedded branch May 13, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants