Suppress gabage collection due to using linq #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Kohei-Yanagida
commented
May 26, 2020
Kohei-Yanagida
commented
- LINQ構文使用によってVRMロード時に発生していたGCを抑制
hiroj
reviewed
May 26, 2020
| .Select(x => x.GetComponent<Renderer>()) | ||
| .Where(x => x != null) | ||
| .Select(x => new RendererFirstPersonFlags | ||
| var rendererComponents = transform.GetComponentsInChildren<Renderer>(); |
There was a problem hiding this comment.
念のためTraverseとGetComponentsInChildrenが同じ結果になることをテストに追加していただけますか？
There was a problem hiding this comment.
と思いましたがここは順番が関係なさそうなのでこのままで大丈夫です
hiroj
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.